Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 2096: unintuitive behavior when an observable is created and then observed within the same computed #2097

Closed
wants to merge 1 commit into from
Closed

Fix for issue 2096: unintuitive behavior when an observable is created and then observed within the same computed #2097

wants to merge 1 commit into from

Conversation

melnikov-s
Copy link
Contributor

@melnikov-s melnikov-s commented Sep 5, 2019 •
edited
Loading

  • [x ] Added unit tests
  • [x ] Verified that there is no significant performance drop (npm run perf)

Fixes #2096

Not sure if this is the best approach as I don't have much experience with the mobx code base but it seemed to be the path of least resistance.

@melnikov-s
Fix for issue 2096: unintuitive behavior when an observable is create…
144ca5d 
…d and then observed within the same computed
@danielkcz danielkcz requested a review from urugator September 6, 2019 05:08
@urugator
Copy link
Collaborator

urugator commented Sep 24, 2019 •
edited
Loading

Closing due to reasons explained in #2096

@urugator urugator closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urugator urugator Awaiting requested review from urugator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unintuitive behavior when an observable is created and then observed within the same computed
2 participants
@melnikov-s @urugator