Fix array update proxy (important fix) #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviergonz
changed the title
|
@mweststrate sorry to bother you, but I think it is an important fix that might require a bugfix release (sorry!) |
aretecode
reviewed
Jun 4, 2019
| @@ -444,7 +444,7 @@ const arrayExtensions = { | |||
| if (hasInterceptors(adm)) { | |||
| const change = interceptChange<IArrayWillChange<any>>(adm as any, { | |||
| type: "update", | |||
| object: this.proxy, | |||
| object: adm.proxy as any, // since "this" is the real array we need to pass its proxy | |||
There was a problem hiding this comment.
shouldn't this be tested to make sure it doesn't happen again and to show what it fixed?
mweststrate
approved these changes
Jun 5, 2019
|
Approved @ItamarShDev, interested in releasing this as a patch on 5.10? Doesn't need a back-port. Invoking Squash merge is probably the clearest in this case Thanks! |
aretecode
approved these changes
Jun 6, 2019
|
Sure! Will try soon |
|
Just published it myself since it was taking a bit too long, hope you don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently my fix to send the array proxy in the update event wasn't ok.
I didn't take into account that "set" is called with the actual proxied array as "this", therefore adm.proxy has to be used instead
Without this fix change.object in array update events is set to "undefined" :-/