Updated PropertyDescriptor type to use the latest flow core definition #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please remove the prettier commit? thank you |
|
@ItamarShDev if we don't squash it it will be displayed as two separate commits in the git history-who cares if it's 2 PRs or 1? The source of truth is the git history, not the github PR history. |
|
@tbezman ideally keep prettier out next time indeed (or do it as separate PR), makes reviewing and merging harder. I'll try to cherry-pick the descriptor commit to the master branch as well, hope it will work out :) |
mweststrate
pushed a commit
that referenced
this pull request
Jun 4, 2019
|
Released as 4.10.0 / 5.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating our MobX to version 4 at Coinbase. We came across an issue with the flow typings for
PropertyDescriptor. The first commit is us just running prettier. The second commit is where we bring in the Flow core definition ofPropertyDescriptor.Can we make sure this is released under version 4?