Make ObservableSet backport compatible with IE11 #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation and the backport made use of Array.from. Mobx4 appears to avoid the usage of Array.from by instead using its internal iteratorToArray function. All Array.from calls have been replaced by iteratorToArray calls. Also, IE11 lacks the "values" function on Sets, and even ObservableSet.toString depends on it. A workaround has been implemented that allows the ObservableSet.values to work even in IE11.
|
Great, thanks a lot! |
mweststrate
approved these changes
Mar 1, 2019
|
Released as 4.9.3, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation and the backport made use of Array.from.
Mobx4 appears to avoid the usage of Array.from by instead using its
internal iteratorToArray function. All Array.from calls have been
replaced by iteratorToArray calls.
Also, IE11 lacks the "values" function on Sets,
and even ObservableSet.toString ended up depending on it.
A workaround has been implemented that allows the
ObservableSet.values to work even in IE11.