Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor types added #1786

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Conversation

geneoes
Copy link
Contributor

@geneoes geneoes commented Oct 23, 2018

I added minor missing types that I found useful when developing with mobx+ts for the first time

PR checklist:
* [ ] Added unit tests
* [ ] Updated changelog
* [ ] Updated docs (either in the description of this PR as markdown, or as separate PR on the `gh-pages` branch. Please refer to this PR). For new functionality, at least [API.md](https://github.com/mobxjs/mobx/blob/gh-pages/docs/refguide/api.md) should be updated
* [x] Added typescript typings
* [ ] Verified that there is no significant performance drop (`npm run perf`)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.717% when pulling 2db3d4d on geneoes:minor-types-observablearray into 524bf2c on mobxjs:master.

@mweststrate mweststrate merged commit 04dc620 into mobxjs:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants