Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for obs. arrays on keys. Fixes #1600 #1601

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Add support for obs. arrays on keys. Fixes #1600 #1601

merged 1 commit into from
Aug 14, 2018

Conversation

YarnSphere
Copy link
Contributor

I went ahead and just did it, feel free to refute it if you believe that the change shouldn't be made.
If you're willing to accept it, should I add an entry to the changelog?

PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 93.908% when pulling 6d38609 on nunocastromartins:support-arrays-on-keys into 4874fd5 on mobxjs:master.

@mweststrate
Copy link
Member

Looking great, thanks! Sorry for the slow follow up :)

@mweststrate mweststrate merged commit 2d6cab7 into mobxjs:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants