Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix for flow typing #1399

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Minor fix for flow typing #1399

merged 1 commit into from
Mar 14, 2018

Conversation

ismailhabib
Copy link
Contributor

The flow typing which accept generator with one and two parameters are returning Promise instead of CancellablePromise.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.755% when pulling 2dc4f1d on ismailhabib:master into 6f7dc09 on mobxjs:master.

@mweststrate
Copy link
Member

Yay! Thanks

@mweststrate mweststrate merged commit ea47438 into mobxjs:master Mar 14, 2018
@mweststrate
Copy link
Member

...but but, are you using flow :-P?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ismailhabib @coveralls @mweststrate