WIP: Make observable map structurally match an ES6 Map #1361
Conversation
| @@ -13,7 +13,7 @@ | |||
| "noImplicitAny": false, | |||
| "moduleResolution": "node", | |||
| "lib": [ | |||
| "es5", | |||
| "es2015", | |||
There was a problem hiding this comment.
Had to change this so I could use Symbol.toStringMap and Symbol.iterator in the typings.
| @@ -40,9 +41,19 @@ export interface IMap<K, V> { | |||
| get(key: K): V | undefined | |||
| has(key: K): boolean | |||
| set(key: K, value?: V): this | |||
| // prettier-ignore | |||
| [Symbol.toStringTag]: "Map"; // necessary semicolon | |||
There was a problem hiding this comment.
prettier gets rid of this semi, but it is needed. Not familiar enough with prettier to know if there's a better way.
(Or maybe there's a better way to let TS know it's the end of the statement, but I don't know it).
| @@ -22,7 +22,7 @@ | |||
| "quick-build": "tsc --pretty", | |||
| "small-build": "node scripts/build.js", | |||
| "lint": "tslint -c tslint.json src/*.ts src/types/*.ts src/api/*.ts src/core/*.ts src/utils/*.ts", | |||
| "size": "size-limit 20KB lib/mobx.js", | |||
| "size": "size-limit 21KB lib/mobx.js", | |||
There was a problem hiding this comment.
Apparently I've bumped the size over the limit by 10 bytes. I don't know if this is the change you would want - but this should get things to pass
|
Thanks! Would it ok for you to target the |
|
Ah, I hadn't realised there was a mobx4 branch with some of the TS configuration already changed. I'll have to resolve conflicts before this one is ready to go. |
marcfallows
changed the title
|
@marcfallows don't bother, Ill merge your changes, that is propbably easier |
|
Merged, thanks! |
Observable map now has the typings to structurally match
Map. Also implementstoStringTagproperly as if it were a Map. This should resolve #1204Thanks for taking the effort to create a PR!
If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with
WIP:if they are not yet finishedPR checklist:
gh-pagesbranch. Please refer to this PR). For new functionality, at least API.md should be updatednpm run perf)Feel free to ask help with any of these boxes!
The above process doesn't apply to doc updates etc.