Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try/catch errors when globalstate.disableErrorBoundaries is on. #1262

Closed
wants to merge 1 commit into from

Conversation

NaridaL
Copy link
Contributor

@NaridaL NaridaL commented Dec 4, 2017

Fixes #1241

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests Not sure if testable: As default behavior is to rethrow the exception, different behavior is only noticeable when debugging.
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings N/A
  • Verified that there is no significant performance drop (npm run perf)
'PERSIST' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] perf: `npm run small-build && PERSIST=true time node --expose-gc test/perf/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] perf script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@NaridaL
Copy link
Contributor Author

NaridaL commented Dec 4, 2017

I'm getting the same errors on master, I don't the think the failing build is from my changes...

@NaridaL
Copy link
Contributor Author

NaridaL commented Dec 13, 2017

@mweststrate any feedback?

@mweststrate
Copy link
Member

@NaridaL sorry for the late response! But I think this is a useful feature and I will merge it into the Mobx 4 branch :)

@mweststrate
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants