Don't pass undefined to custom equality checks on becoming observed a… #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoble
commented
Oct 19, 2017
| @@ -682,7 +682,7 @@ test("peeking inside autorun doesn't bork (global) state", t => { | |||
| t.equal(b.diffValue, 0) | |||
| t.equal(b.lowestObserverState, 0) | |||
| t.equal(b.unboundDepsCount, 1) | |||
| t.equal(b.value, undefined) | |||
| t.notEqual(b.value, 3) | |||
There was a problem hiding this comment.
I'm not particularly happy with this assertion. I wanted to write something like t.ok(isCaughtException(b.value)) but as far as I can tell neither CaughtException nor isCaughtException are exported from mobx.ts. I considered exporting them from mobx.ts, but that's changing public API. Also considered importing them from core/derivation.ts directly, but that's inconsistent with all other tests.
This feels like it's still achieving the goal of the assertion (ensuring that the cached value is cleared) while avoiding those problems.
I'm open to suggestions of other approaches.
|
Made a minor improvement and merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gain
This PR attempts to fix #1208.
I've extended one of the tests added in #951 to cover this bug, but I'm not sure if that's sufficient. The difference between
test/babel/*.js,test/typescript/*.js, andtest/*.jsisn't clear to me so please let me know if I should add more tests.PR checklist:
npm run perf)