Support weex #1163
Merged
Support weex #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweststrate
reviewed
Sep 18, 2017
| @@ -119,6 +119,29 @@ function inherit(ctor, proto) { | |||
| } | |||
| inherit(StubArray, Array.prototype) | |||
|
|
|||
| // Weex freeze Array.prototype | |||
There was a problem hiding this comment.
Thanks for the PR.
Could you make the patch conditional? That is, only apply the patch if the properties are actually not writable (such as in the weex case)? This avoids putting more methods in the prototype chain when it is not really needed.
|
Done. Now the patch only works when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Weex is a framework like
ReactNative. It runs javascript in JavaScriptCore/V8 runtime and freezedArray.prototype.Mobx is a awesome library so I want make it works in weex.
ObservableArrayin mobx overridepush/sort/etccould not run in weex. We'd better make this original array method writeable inStubArray.prorotype.See alibaba/weex#1529
PR checklist:
gh-pagesbranch. Please refer to this PR). For new functionality, at least API.md should be updatednpm run perf)