#1121 add possibility to redefine a computed property #GoodnessSquadKyiv #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweststrate
reviewed
Sep 5, 2017
test/observables.js
Outdated
|
|
||
| t.equal(observeCalls, 1) | ||
| t.equal(reactionCalls, 1) | ||
|
|
There was a problem hiding this comment.
Thanks for this PR!. Could you add a assertion that a.surface is 22 here?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the effort to create a PR!
If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with
WIP:if they are not yet finishedPR checklist:
gh-pagesbranch. Please refer to this PR). For new functionality, at least API.md should be updatednpm run perf)Feel free to ask help with any of these boxes!
The above process doesn't apply to doc updates etc.