Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce isStrictModeEnabled #464

Closed
mweststrate opened this issue Aug 7, 2016 · 3 comments
Closed

Introduce isStrictModeEnabled #464

mweststrate opened this issue Aug 7, 2016 · 3 comments

Comments

@mweststrate
Copy link
Member

deprecate useStrict() without arguments?
@vonovak
Copy link
Contributor

vonovak commented Aug 7, 2016

imho isStrictModeEnabled sounds like something that could be assigned to a variable or checked in a condition like if(isStrictModeEnabled).... If the intent is to enable the strict mode then I'd call it simply enableStrictMode

@mweststrate
Copy link
Member Author

Related cause for this issue: zalmoxisus/mobx-remotedev#3 (comment), useStrict() without arg was introduced recently, but not backward compatible so should be deprecated

mweststrate added a commit that referenced this issue Aug 30, 2016
@mweststrate
Implemented #464 isStrictModeEnabled
00c780b
@mweststrate
Copy link
Member Author

Already released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vonovak @mweststrate