Should be using prepare rather than postinstall step for website dependency install

[benjamind]

In the latest Mobx 5.14.1, Installing mobx as a dependency is resulting in the postinstall script executing which is trying to install the dependencies of the website folder which is not distributed in the package resulting in errors like this during dependency installation:

$ yarn --cwd website install
Killed
yarn install v1.16.0
error Directory "/home/circleci/project/node_modules/mobx/website" doesn't exist
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.

Reproduction:

• install as a dependency of any project.

Easy fix is to change postinstall to prepare. prepare will execute only on local installation, and not during installation as a dependency.

[danielkcz]

Thanks for the report, that's definitely bad and ugly bug. We will sort it out soon.

[danielkcz]

Or you will, that's also an option :D

[vnesek]

What about npm users, is using yarn requirement now?

[danielkcz]

No, these lifecycle scripts work the same across yarn & npm.

Point is that, postinstall is executed when installing mobx on your machine, but prepare is only for development of mobx.

[vnesek]

Running on a system without yarn installed:

user@local> npm i

> [email protected] postinstall /Users/vnesek/Workspace/ddex-front/node_modules/mobx
> yarn --cwd website install

sh: yarn: command not found

[danielkcz]

Published 5.14.2 ... note there is no 4.14.2 as MobX 4 wasn't affected.

[benjamind]

@vnesek yarn has been required for mobx development for a long time now I think. It is not required to consume mobx as a dependency though.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.