suggestion: entries(observableMap)

[xaviergonz]

Would go great alongside the new values(), and keys()

[mweststrate]

Was thinking about that. But note that Array.from(observableMap) achieves the same Op do 15 mrt. 2018 om 18:34 schreef Javier Gonzalez < [email protected]>:

…

Would go great alongside the new values(), and keys() — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1416>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhKwGbOytJCymLuAJ5z1D8yyi5QWkks5teqYvgaJpZM4SslUA> .

[xaviergonz]

Yep, but I guess entries (as well as its values and keys friends) is an optimized version that doesn't try to create an array if it is already an array?

[sorenhoyer]

If there's any performance improvement in entries() as opposed to Array.from(map) then I definitely agree.

Just a heads up: https://jsperf.com/set-iterator-vs-foreach/4

We should probably use array spread syntax [...myMap.values()] instead of array.from, since it seems to be much better optimized for both current and especially the upcoming browsers (look at the huge performance improvement in current bleeding edge chrome 67 canarian - just verified it)

[mweststrate]

PR is welcome for this one! Should be pretty straight forward :)

[samjacobclift]

Is this not already implemented here? Or am I missing something?

[quanganhtran]

Should the issue be resolved already? @xaviergonz

[mweststrate]

No, this issue is about a top-level api, not a map api, like these: https://github.com/mobxjs/mobx/blob/8cccd9330a88a2a4dee4c038a60c1fac8ed965d6/src/api/object-api.ts Op vr 4 mei 2018 om 10:28 schreef quanganhtran <[email protected]>:

…

Should the issue be resolved already? @xaviergonz <https://github.com/xaviergonz> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhKhZcwTz3WeZsUXZ2u92uR5DVQfyks5tvBEpgaJpZM4SslUA> .

[samjacobclift]

I see I’ll give the implementation a go!

[samjacobclift]

here is the PR 👍 #1536

[mweststrate]

Released in 4.3.0