[3.6.0] "TypeError: Invalid calling object" error in IE11

[le0nik]

This error happens when reactions have { compareStructural: true } option. It started happening in [email protected] and originates on this line:

mobx/src/utils/eq.ts

Line 32 in 8f7f4a3

var className = toString.call(a)

The reason is that toString is called as a global function. IE11 throws TypeError: Invalid calling object when it happens. Object.prototype.toString doesn't result in this error.

[mweststrate]

Interested in creating a PR? Op wo 28 feb. 2018 om 12:19 schreef Leonid Nikiforenko < [email protected]>:

…

This error happens when reactions have { compareStructural: true } option. It started happening in ***@***.*** and originates on this line: https://github.com/mobxjs/mobx/blob/8f7f4a3e24e47b001c7e3073c69576086619c575/src/utils/eq.ts#L32 The reason is that toString is called as a global function. IE11 throws TypeError: Invalid calling object when it happens. Object.prototype.toString doesn't result in this error. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1358>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhC-d9gNnpoNjx2iIK4WJAK3Fvn5Gks5tZTZLgaJpZM4SWfTi> .

[le0nik]

Sure, the only thing stopping me is that i'm not quite sure how to test it here and whether it needs to be tested.

[mweststrate]

If you leave a comment on the fixed line, and you test it locally (`yarn run small-build` in the mobx repo) and then `npm install <path to your mobx repo>` in your test project, you should be able to verify the changes Op wo 28 feb. 2018 om 12:24 schreef Leonid Nikiforenko < [email protected]>:

…

Sure, the only thing stopping me is that i'm not quite sure how to test it here and whether it needs to be tested. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1358 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhM2zhmEJT4OFn8aA9bavv7WiTD8Lks5tZTdMgaJpZM4SWfTi> .

[le0nik]

Ah, no i meant whether i can(and need to) actually write a test for this case as i don't see saucelabs integration or karma config in the project.

[le0nik]

#1359

[mweststrate]

Correct, the project used tape-run in the past, but that project kinda died, and since it never caught an actual bug (by far most browser bugs where safari, which I cant run locally), I didn't bother migrating to something else. If someone has experience with setting up running unit tests on different browser stacks, a PR that runs the suite on different browsers in the travis CI is welcome :) Op wo 28 feb. 2018 om 12:35 schreef Leonid Nikiforenko < [email protected]>:

…

#1359 <#1359> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1358 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhAdC2u1pOt85greEL06ug3HaIfXRks5tZTnjgaJpZM4SWfTi> .

[mweststrate]

Released as 3.6.1. Thanks!