Skip to content

Commit

Permalink
Merge pull request #1394 from jjinux/changelog-observable-computed-get
Browse files Browse the repository at this point in the history
Added something missing from the CHANGELOG
  • Loading branch information
mweststrate authored Mar 13, 2018
2 parents b68df65 + 7bb3f14 commit 6d8c6af
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,18 @@ observable({
})
```

By the way, if you have code such as:

```
observable({
@computed get someProp() { ... }
});
```

That code will no longer work. Rather, reactions will fail silently. Remove `@computed`.
Note, this only applies when using observable in this way; it doesn't apply when using
`@observable` on a property within a class declaration.

### Misc

* Fixed #701: `toJS` sometimes failing to convert objects decorated with `@observable` (cause: `isObservable` sometimes returned false on these object)
Expand Down

0 comments on commit 6d8c6af

Please sign in to comment.