Merge pull request #1150 from dbarabashdev/971-action-error-message

@action get func(){} have accurate error messages #GoodnessSquadKyiv
mobxjs · Aug 31, 2017 · 562f935 · 562f935
2 parents 2973fe1 + a92e841
commit 562f935
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/api/action.ts b/src/api/action.ts
@@ -120,6 +120,9 @@ function namedActionDecorator(name: string) {
             descriptor.configurable = true
             return descriptor
         }
+        if (descriptor !== undefined && descriptor.get !== undefined) {
+            throw new Error("[mobx] action is not expected to be used with getters");
+        }
         // bound instance methods
         return actionFieldDecorator(name).apply(this, arguments)
     }

diff --git a/test/babel/babel-tests.js b/test/babel/babel-tests.js
@@ -56,6 +56,17 @@ test("babel", function(t) {
     t.end()
 })
 
+test("should not be possible to use @action with getters", t => {
+    t.throws(() => {
+        class A {
+            @action get Test() { }
+        }
+    }, new Error('[mobx] action is not expected to be used with getters'))
+
+    mobx.extras.resetGlobalState()
+    t.end()
+})
+
 test("babel: parameterized computed decorator", t => {
     class TestClass {
         @observable x = 3