Fix #3582, AbortSignal leaks @types/node (#3583)

mobxjs · Jan 14, 2023 · 2bccc5b · 2bccc5b
1 parent 7095fa4
commit 2bccc5b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/.changeset/quiet-kiwis-rhyme.md b/.changeset/quiet-kiwis-rhyme.md
@@ -0,0 +1,5 @@
+---
+"mobx": patch
+---
+
+fix #3582: AbortSignal leaks @types/node
diff --git a/packages/mobx/src/api/when.ts b/packages/mobx/src/api/when.ts
@@ -9,11 +9,19 @@ import {
     allowStateChanges
 } from "../internal"
 
+// https://github.com/mobxjs/mobx/issues/3582
+interface GenericAbortSignal {
+    readonly aborted: boolean
+    onabort?: ((...args: any) => any) | null
+    addEventListener?: (...args: any) => any
+    removeEventListener?: (...args: any) => any
+}
+
 export interface IWhenOptions {
     name?: string
     timeout?: number
     onError?: (error: any) => void
-    signal?: AbortSignal
+    signal?: GenericAbortSignal
 }
 
 export function when(
@@ -90,8 +98,8 @@ function whenPromise(
             disposer()
             reject(new Error("WHEN_ABORTED"))
         }
-        opts?.signal?.addEventListener("abort", abort)
-    }).finally(() => opts?.signal?.removeEventListener("abort", abort))
+        opts?.signal?.addEventListener?.("abort", abort)
+    }).finally(() => opts?.signal?.removeEventListener?.("abort", abort))
     ;(res as any).cancel = cancel
     return res as any
 }