Update computedFn warning to respect mobx global computedRequiresReaction #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses this issue: #268
This will allow consumers to test code wrapped with
computedFn
easily by usingCurrently in order to test a computed funciton you either:
--silent
in jestautorun
in each test or during setup before each test.Notes
There will be a behavioural change in when a
computedFn
warning is triggered as the default forcomputedRequiresReaction
is false. This will make it consistent in behaviour with the basecomputed
, but if it is desirable to maintain the existing behavior we could add another option... I'm not sure where that would live, as mobx-utils has no global state and it seems odd to putcomputedFnRequiresReaction
within the mobx global state - thoughts?