Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to 3.8.3 and Prettier to 2.0.4 #248

Merged
merged 3 commits into from
May 4, 2020

Conversation

NaridaL
Copy link
Collaborator

@NaridaL NaridaL commented Apr 10, 2020

I want to use ?. in my other pull request.

@coveralls
Copy link

coveralls commented Apr 10, 2020

Coverage Status

Coverage remained the same at 93.489% when pulling cf9d0f3 on NaridaL:typescript3.8 into 7f4df9b on mobxjs:master.

@NaridaL
Copy link
Collaborator Author

NaridaL commented Apr 10, 2020

@xaviergonz gonna tag you because you were active here recently 😄

@mweststrate
Copy link
Member

Please do make sure you don't commit unrelated files. Your prettier configs seems to deviate from what is used in this repo, making this PR much larger than it should be. Feel free to commit a .prettierrc file to fix this if this avoids this repo conflicting with your IDE defaults.

@@ -8,7 +8,7 @@ const readline = require("readline")

const rl = readline.createInterface({
input: process.stdin,
output: process.stdout
output: process.stdout,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the result of using a different prettier config or version. Please align your local settings with this repo, or don't stage the unrelated files, or creating a PR that locks the config and prettier version would be even more awsome!

Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unrelated files touched by this PR

@NaridaL NaridaL changed the title Update TypeScript to 3.8.3 Update TypeScript to 3.8.3 and Prettier to 2.0.4 Apr 15, 2020
@NaridaL
Copy link
Collaborator Author

NaridaL commented Apr 15, 2020

Yeah sorry, this PR should be called "update typescript and prettier". Prettier 2 supports the TS 3.8 features.

Prettier 2 contains some breaking changes concerning default options and formatting, hence the number of changes. See also https://prettier.io/blog/2020/03/21/2.0.0.html

As the new defaults make sense I thought I'd just reformat everything although I guess we could manually change the config so it doesn't change much.

@mweststrate
Copy link
Member

@NaridaL that makes sense, thanks for the explanation! The new dangling commas everywhere, is that a change in the prettier defaults? If it isn't, the .prettierrc should be updated accordingly

@mweststrate
Copy link
Member

Answer: yes, it is the new default

@NaridaL
Copy link
Collaborator Author

NaridaL commented May 4, 2020

@mweststrate do you mind hitting merge? Or you can add me as maintainer here too.

Also, I'd appreciate you taking a look at #245 😄

@mweststrate
Copy link
Member

@NaridaL sorry, very swamped atm! I'll send an invite.

@mweststrate mweststrate merged commit 4b59640 into mobxjs:master May 4, 2020
@NaridaL NaridaL deleted the typescript3.8 branch May 24, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants