Support IComputedOptions in createTransformer #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the same vain as mobxjs#215, it would be great to use a custom equals function with createTransformer, to avoid bubbling bubbling recomputes of transformers that return arrays. This commit passes the options through to the internal `computed`. The name option is not passed through, since that can be changed with the `debugNameGenerator` option.
mweststrate
reviewed
Oct 31, 2019
src/create-transformer.ts
Outdated
| onCleanup?: (resultObject: B | undefined, sourceObject?: A) => void | ||
| debugNameGenerator?: (sourceObject?: A) => string | ||
| } | ||
| | Exclude<IComputedValueOptions<B>, "name"> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for seeing that - I've updated the PR.
|
Hullooo. Is this still going ahead? |
|
Released as 5.5.3 |
|
Shouldn't this PR be closed if it was merged and released? :) |
|
It should! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #215, it would be great to use a custom equals
function with
createTransformer, to avoid bubbling bubbling recomputesof transformers that return arrays/maps/etc.
This commit passes the options through to the internal
computed. Thename option is not passed through, since that can be changed with
the
debugNameGeneratoroption.