[Internal] Cleanup 'createNode' and related codepaths #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ok, had to split create/finalize back, because |
k-g-a
changed the title
Member
Author
|
I advice merging #959 first - it will conflict with this one. |
Member
|
@k-g-a could you rebase this branch and see what remains? |
Member
Author
|
@mweststrate, sure. I’ll have a look at Monday |
# Conflicts: # packages/mobx-state-tree/src/core/node/object-node.ts # packages/mobx-state-tree/src/core/node/scalar-node.ts # packages/mobx-state-tree/src/types/complex-types/model.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is purely internal.
Basically it replacescreateNewInstance+finalizeNewInstancecombo with just oneinitializeInstancecall.Another step to make code cleaner was to remove
createNewInstance/finalizeNewInstancefromcreateNode's arguments, as those were taken from type anyway (insidetype.instantiate). As we have type insideObjectNode/ScalarNodethere is not need to pass those two methods 3 calls deep separately.As a side effect this makes
createNodeand Node's constructor's calls less polymorphic and slightly reduces subsequent calls time.