This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 90
Add test for proper reaction disposal in StrictMode #119
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2a99a30
Add test for proper reaction disposal in StrictMode
Royston-Shufflebotham-i2 2146f1c
Use jest-mock-console instead of mocking console.error by hand
Royston-Shufflebotham-i2 b568eff
Move test into separate useObserver test file
Royston-Shufflebotham-i2 25f6177
Add a second test to verify that reactions are disposed after unmount
Royston-Shufflebotham-i2 ef063cb
Remove 'leak' test as it's a separately-solvable issue.
Royston-Shufflebotham-i2 6a8b792
Track whether the current component has been committed before forcing…
Royston-Shufflebotham-i2 d9f8fe5
Remove the now-unused useUnmount
Royston-Shufflebotham-i2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
jest-console
instead of this boilerplate :) It's even used in this test file already :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Will do. I don't normally use Jest, so I wasn't aware of that one.