Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes in review request #22

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Implement changes in review request #22

merged 2 commits into from
Jul 2, 2024

Conversation

MahmoudAshraf97
Copy link

No description provided.

@MahmoudAshraf97
Copy link
Author

@Jiltseb

@Jiltseb Jiltseb self-requested a review July 2, 2024 08:56
Copy link
Collaborator

@Jiltseb Jiltseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing the same changes :) Could you also remove duplicate detection function?

@Jiltseb Jiltseb merged commit 3ffb18f into mobiusml:master Jul 2, 2024
@Jiltseb
Copy link
Collaborator

Jiltseb commented Jul 2, 2024

Also please add changes for: "comment/remove unnecessary variable"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants