v201:call,call_result,datatypes: complete and corrected type annotations #562
+165
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change is a superset of #529 and contains all of those fixes. |
malsyned
force-pushed
the
ocpp-2.0.1-payload-correct-types
branch
from
ea3d8ca
to
b729d04
Compare
|
The PR contains at least a serious fix to total_cost type, which is a showstopper at implementing an OCPP2 server compliant with pricing regulation with that library. The rest of PR is also refining properly a bunch of types definition. |
malsyned
force-pushed
the
ocpp-2.0.1-payload-correct-types
branch
from
9ab973a
to
534be5d
Compare
|
I rebased this so it will merge cleanly with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I groveled through the v2.0.1 spec and updated all of the type signatures to be complete and accurate to the best of my ability.
I did this to support some work I'm doing to make a variant of
@onthat converts the JSON back to Python objects, but I think it will be useful to anyone using the library with an IDE, so I'm submitting it as a separate pull request.