Fix cryptic "SocketException" when API token is invalid #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekpacia
changed the title
amanjeetsingh150
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aimed at aiding with investigation of #1856
Problem
When API token is invalid, CLI shows a cryptic "socket exception" instead of "invalid token".
Root cause
Our server closes request when it determines that request is unauthorized/has bad token.
However OkHttp did not handle that situation before v4.11.0, and we used 4.10.0. Instead of gracefully handling closed connection and returning the response, it still tried writing to the connection (that had been already closed by the server), and crashed with
socket exception: broken pipe.fyi @igorsmotto @amanjeetsingh150
More context