Fixing several issues that make the projects unusable. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
moaxcp
commented
Jul 4, 2024
moaxcp
commented
- Fixing XAuthority when parsing number
- switched back to junixsocket as jdk does not support sockets only SocketChannel
- Fixing usage of io.freefair.lombok in protocol projects. The module-path was not being set on the delombok task
- fixing delombok by removing lombok from projects using junixsocket. Delombok does not support mutli-release jar files.
moaxcp
force-pushed
the
fix-several-issues
branch
from
316f2e4 to
fc15101
Compare
moaxcp
force-pushed
the
fix-several-issues
branch
2 times, most recently
from
ae7a697 to
38fec81
Compare
* Fixing XAuthority when parsing number * switched back to junixsocket as jdk does not support sockets only SocketChannel * Fixing usage of io.freefair.lombok in protocol projects. The module-path was not being set on the delombok task * fixing delombok by removing lombok from projects using junixsocket. Delombok does not support mutli-release jar files. * Switched back to junixsocket
moaxcp
force-pushed
the
fix-several-issues
branch
from
38fec81 to
88bd608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.