Completion Request should return CompletionList #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in microsoft/language-server-protocol#39 statically typed languages like Java do not support mixed return types, which in the case of Completion Request is `CompletionItem[] | CompletionList`. Thus Typefox - the Java client of the language server protocol - accepts only `CompletionList`, which contains `CompletionItem[]`. In order to work with Eclipse Che and other IDEs using the Typefox client, the Completion Request handler in the PHP language server should return `CompletionList` instead of `CompletionItems[]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in microsoft/language-server-protocol#39 statically typed languages like Java do not support mixed return types, which in the case of Completion Request is
CompletionItem[] | CompletionList.Thus Typefox - the Java client of the language server protocol - accepts only
CompletionList, which containsCompletionItem[].In order to work with Eclipse Che and other IDEs using the Typefox client, the Completion Request handler in the PHP language server should return
CompletionListinstead ofCompletionItems[].