Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Aug 5, 2025

This branch has a git diff cbrnr/restructure that is empty (so should be equivalent), but better blame:

@cbrnr WDYT?

Closes #347
Closes #349

Must be merged by rebase rather than squashed to work

@larsoner
Copy link
Member Author

larsoner commented Aug 5, 2025

FYI the way to do this quickly was to use the git-split.sh script above, then git checkout cbrnr/restructure <filenames> and commit the result. So @cbrnr your splitting work is implicitly in there still!

@larsoner larsoner changed the title Restructure2 MAINT: Split into submodules Aug 5, 2025
@cbrnr
Copy link
Contributor

cbrnr commented Aug 5, 2025

It's all authored by you?

@larsoner
Copy link
Member Author

larsoner commented Aug 5, 2025

Yep. If you want authorship credit you can do in a new branch:

  1. Copy the git-split.sh script linked previously to some place you can execute it (and set the execute bit)
  2. git-split.sh _pg_figure.py _colors.py etc. repeatedly
  3. git checkout origin/restructure <filenames> where <filenames> has all changed files from your existing PR
  4. `git commit -am 'FIX: Deletions and insertions'

It's more or less what I did. Should be very quick

@cbrnr
Copy link
Contributor

cbrnr commented Aug 8, 2025

Superseded by #351.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split into multiple files

2 participants