MRG: Test fnirs channel structures for chromophore data#9185
Merged
larsoner merged 3 commits intomne-tools:mainfrom Mar 23, 2021
Merged
MRG: Test fnirs channel structures for chromophore data#9185larsoner merged 3 commits intomne-tools:mainfrom
larsoner merged 3 commits intomne-tools:mainfrom
Conversation
Member
Author
|
@larsoner could you please review. This should be the last improvement to these checks, I think I have covered most edge cases now (famous last words). |
rob-luke
changed the title
larsoner
reviewed
Mar 23, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Otherwise LGTM
I'll push a commit for my suggestion since it's almost trivial, then we can merge
Member
|
Thanks @rob-luke ! |
Member
Author
|
Thanks @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Preparation for #9141
What does this implement/fix?
Adds checking of fNIRs channel naming structure for data after transformation to chromophore.
Previously all testing was done on the raw data or after transformation to optical density. But with possibility of people creating their own data structures without the readers I have added additional error checking for the hbo/hbr data type.
Additional information
This is the last addition I have planned in preparation for #9141