-
Notifications
You must be signed in to change notification settings - Fork 1.4k
MRG, ENH: Add ori on MRI slices #8188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, excited to see how the examples come back :)
this image seems wrong: https://21931-1301584-gh.circle-artifacts.com/0/dev/_images/sphx_glr_plot_mixed_norm_inverse_003.png and so is this one to some extent : https://21931-1301584-gh.circle-artifacts.com/0/dev/_images/sphx_glr_plot_dipole_fit_001.png also for some reason the glyph in glass brain in : https://21931-1301584-gh.circle-artifacts.com/0/dev/auto_examples/inverse/plot_time_frequency_mixed_norm_inverse.html#sphx-glr-auto-examples-inverse-plot-time-frequency-mixed-norm-inverse-py do not show up. I should see 2 sources. |
This is (literally) a matter of perspective (projection), and illustrates why this is so useful. Here is the same image on my machine: Then rotated to almost the three orthogonal views -- only almost so you can actually tell that there are two arrows...
This is true in I'll open a separate issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed. Really perfect !
thx @larsoner
sorry to notice this too late, but there is actually something off about those images. The "stem" that connects the dipole vector to the orthogonal surfaces seems to be partially occluded by the MRI slices. So, hopefully just a z-order problem? |
This is a matplotlib 3D bug. Even when I move them 1 cm inward, the z ordering gets messed up / occluded. I think we have to live with it unless we want to fix their 3D routines... |
…ysionet * upstream/master: ENH: Add message (mne-tools#8193) ENH: Allow writing BEM in H5 format (mne-tools#8191) ENH: Add ori on MRI slices (mne-tools#8188) Ricoh new files (mne-tools#8187) MRG: Split _timeviewer.py into multiple files (mne-tools#8181) ENH: Better memory efficiency (mne-tools#8185) MRG: Trimming Sleep Physionet recordings to avoid W imbalance (mne-tools#8179) MRG, BUG: Fix montage plotting, deduplication, and preload check (mne-tools#8178) Test PSD topomap works with NIRS epochs (mne-tools#8180) MRG, MAINT: Tweak CI versions (mne-tools#8174)
Part of #2995