Skip to content

MRG, ENH: Add ori on MRI slices #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020
Merged

MRG, ENH: Add ori on MRI slices #8188

merged 1 commit into from
Sep 1, 2020

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Sep 1, 2020

Part of #2995

@larsoner larsoner added this to the 0.21 milestone Sep 1, 2020
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, excited to see how the examples come back :)

@larsoner
Copy link
Member Author

larsoner commented Sep 1, 2020

this image seems wrong:

This is (literally) a matter of perspective (projection), and illustrates why this is so useful. Here is the same image on my machine:

Screenshot from 2020-09-01 15-02-09

Then rotated to almost the three orthogonal views -- only almost so you can actually tell that there are two arrows...

Screenshot from 2020-09-01 15-02-19

Screenshot from 2020-09-01 15-02-24

Screenshot from 2020-09-01 15-02-28

also for some reason the glyph in glass brain

This is true in master:

https://mne.tools/dev/auto_examples/inverse/plot_time_frequency_mixed_norm_inverse.html#sphx-glr-auto-examples-inverse-plot-time-frequency-mixed-norm-inverse-py

I'll open a separate issue

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. Really perfect !

thx @larsoner

@agramfort agramfort merged commit e77de58 into mne-tools:master Sep 1, 2020
@drammock
Copy link
Member

drammock commented Sep 1, 2020

sorry to notice this too late, but there is actually something off about those images. The "stem" that connects the dipole vector to the orthogonal surfaces seems to be partially occluded by the MRI slices. So, hopefully just a z-order problem?

@larsoner
Copy link
Member Author

larsoner commented Sep 1, 2020

So, hopefully just a z-order problem?

This is a matplotlib 3D bug. Even when I move them 1 cm inward, the z ordering gets messed up / occluded. I think we have to live with it unless we want to fix their 3D routines...

@larsoner larsoner deleted the ori branch September 1, 2020 19:23
larsoner added a commit to hubertjb/mne-python that referenced this pull request Sep 2, 2020
…ysionet

* upstream/master:
  ENH: Add message (mne-tools#8193)
  ENH: Allow writing BEM in H5 format (mne-tools#8191)
  ENH: Add ori on MRI slices (mne-tools#8188)
  Ricoh new files (mne-tools#8187)
  MRG: Split _timeviewer.py into multiple files (mne-tools#8181)
  ENH: Better memory efficiency (mne-tools#8185)
  MRG: Trimming Sleep Physionet recordings to avoid W imbalance (mne-tools#8179)
  MRG, BUG: Fix montage plotting, deduplication, and preload check (mne-tools#8178)
  Test PSD topomap works with NIRS epochs (mne-tools#8180)
  MRG, MAINT: Tweak CI versions (mne-tools#8174)
marsipu pushed a commit to marsipu/mne-python that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants