-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[MRG] Fix compare evokeds #4755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0bd7f49
FIX plot_compared_evokeds grad ci estimation
ktavabi 46c4e6b
Compute stats after computing RMS
ktavabi e7df71f
reorg + simplify grad handling of plot_compare_evokeds
agramfort 9a0aaf5
[ENH] plot_compare_evoked improved line colouring
jona-sassenhagen e863f9a
use auxilary functions
agramfort 0ee9c92
add exception and test for corner case with both cmap and colors
agramfort 451f705
address comments
agramfort af4e181
cosmit, docstrings
jona-sassenhagen 5192e2a
pep8
jona-sassenhagen f1b4ef1
add erics test for grad cis
jona-sassenhagen dbfd361
docstring
jona-sassenhagen c45315d
comments
jona-sassenhagen a789d90
pep8 :|
jona-sassenhagen 5820eb8
comments
jona-sassenhagen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more easily expressed as
ev.ch_names != ch_namesbut you can keep it this way