FIX: Replace use of deprecated Numpy func in GDF reader (Supersedes #13415) #13497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ≥1.24 Note that .encode() was added because np.frombuffer requires bytes.
…string (NumPy ≥1.24) - Now reading a single byte directly from the file handle (fid.read(1)), and parsing it using np.frombuffer with dtype=UINT8. - Added changelog entry (doc/changes/devel/13415.bugfix.rst) and contributor link in doc/changes/names.inc.
for more information, see https://pre-commit.ci
previous condition used != "", which compares against a string, but I think the dev meant to guard against b"" not "". This replaces it with an explicit non-empty-bytes check to make intent clear and behavior correct.
scott-huberty
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
larsoner
approved these changes
Nov 19, 2025
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Thanks @scott-huberty @devparikh0506 !
Member
|
CircleCI failures being fixed by mne-tools/mne-installers#392 |
larsoner
added a commit
to zhijingz/mne-python
that referenced
this pull request
Nov 20, 2025
* upstream/main: ENH: Parse EyeLink BUTTON Events (e.g. from a game controller) (mne-tools#13499) FIX: Fix regression with mne.viz.plot_evoked (mne-tools#13481) DOC: related software doc (mne-tools#13498) FIX: Replace use of deprecated Numpy func in GDF reader (Supersedes mne-tools#13415) (mne-tools#13497) DOC: Link to membership from governance page (mne-tools#13496) [pre-commit.ci] pre-commit autoupdate (mne-tools#13495) BUG: Fix issue with Montage.plot (mne-tools#13494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13414
Closes #13415 (supersedes)
FYI @larsoner I tried to push directly to #13415 But I still don't think I have those rights (got:
remote: Permission to devparikh0506/mne-python.git denied to scott-huberty). Might discuss this with @drammock during our Meeting tomorrow to see if I am doing something wrong.