Skip to content

FIX: Fix add_reference_channels for passing two channels names #13466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

FIX: Fix add_reference_channels for passing two channels names #13466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66ef3e2
FIX: Fix add_reference_channels for passing two channels names
mistraube Oct 28, 2025
40ed1b1
Add whatsnew
mistraube Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/13466.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug with :func:`mne.add_reference_channels` not working correctly when passing more than one channel name, by `Michael Straube`_.
2 changes: 1 addition & 1 deletion mne/_fiff/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def add_reference_channels(inst, ref_channels, copy=True):
"unit_mul": FIFF.FIFF_UNITM_NONE,
"unit": FIFF.FIFF_UNIT_V,
"coord_frame": FIFF.FIFFV_COORD_HEAD,
"loc": ref_dig_array,
"loc": ref_dig_array.copy(),
}
inst.info["chs"].append(chan_info)
inst.info._update_redundant()
Expand Down
4 changes: 4 additions & 0 deletions mne/_fiff/tests/test_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,10 @@ def test_add_reference():
ref_data, _ = raw[[ref_idx, ref_idy]]
assert_array_equal(ref_data, 0)

loc1 = raw.info["chs"][ref_idx]["loc"]
loc2 = raw.info["chs"][ref_idy]["loc"]
assert loc1 is not loc2

# add reference channel to epochs
raw = read_raw_fif(fif_fname, preload=True)
events = read_events(eve_fname)
Expand Down