Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bug with interval calculation #13062

Merged
merged 4 commits into from
Jan 14, 2025
Merged

BUG: Fix bug with interval calculation #13062

merged 4 commits into from
Jan 14, 2025

Conversation

larsoner
Copy link
Member

I had 3s of data sampled at 1s and passed t_window=1. ... and it used a single interval instead of 3. This fixes the logic to use the same mechanics as st_duration.

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.9 label Jan 14, 2025
@larsoner
Copy link
Member Author

@drammock good to go here I think!

@drammock drammock merged commit c0da91d into mne-tools:main Jan 14, 2025
30 checks passed
@drammock drammock deleted the fc branch January 14, 2025 19:19
meeseeksmachine pushed a commit to meeseeksmachine/mne-python that referenced this pull request Jan 14, 2025
@drammock
Copy link
Member

thanks @larsoner

larsoner added a commit that referenced this pull request Jan 16, 2025
qian-chu pushed a commit to qian-chu/mne-python that referenced this pull request Jan 20, 2025
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
larsoner added a commit to larsoner/mne-python that referenced this pull request Jan 24, 2025
* upstream/main: (57 commits)
  Allow lasso selection sensors in a plot_evoked_topo (mne-tools#12071)
  MAINT: Fix doc build (mne-tools#13076)
  BUG: Improve sklearn compliance (mne-tools#13065)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13073)
  MAINT: Add Numba to 3.13 test (mne-tools#13075)
  Bump autofix-ci/action from ff86a557419858bb967097bfc916833f5647fa8c to 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef in the actions group (mne-tools#13071)
  [BUG] Correct annotation onset for exportation to EDF and EEGLAB (mne-tools#12656)
  New feature for removing heart artifacts from EEG or ESG data using a Principal Component Analysis - Optimal Basis Sets (PCA-OBS) algorithm (mne-tools#13037)
  [BUG] Fix taper weighting in computation of TFR multitaper power (mne-tools#13067)
  [FIX] Reading an EDF with preload=False and mixed frequency (mne-tools#13069)
  Fix evoked topomap colorbars, closes mne-tools#13050 (mne-tools#13063)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13060)
  BUG: Fix bug with interval calculation (mne-tools#13062)
  [DOC] extend documentation for add_channels (mne-tools#13051)
  Add `combine_tfr` to API (mne-tools#13054)
  Add `combine_spectrum()` function and allow `grand_average()` to support `Spectrum` data (mne-tools#13058)
  BUG: Fix bug with helium anon (mne-tools#13056)
  [ENH] Add option to store and return TFR taper weights (mne-tools#12910)
  BUG: viz plot window's 'title' argument showed no effect. (mne-tools#12828)
  MAINT: Ensure limited set of tests are skipped (mne-tools#13053)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate on-merge: backport to maint/1.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants