Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subspace in Batch Dimension #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mxlutz
Copy link

@mxlutz mxlutz commented Jul 27, 2023

I am using a Low Rank Transformation along the Batch dimension for MRF reconstruction.

This should be more efficient, as transformation to subspace is performed after gridding and before FFT, so less FFTs have to be performed (described e.g. here: https://onlinelibrary.wiley.com/doi/10.1002/mrm.26639)

Then, e.g. the Adjoint operation can be performed with:

eh = tkbn.KbNufftAdjoint(im_size=fov)
image = eh(kdata, ktraj, ssbasis=ssbasis)

I implemented a really basic version for KbNufft and KbNufftAdjoint (not sure if it's really more efficient), but not sure how to implement it for ToepNufft.

Also, there is no documentation and examples yet, I'm happy to provide them if including the subspace basis along the batch dimension in this repository makes sense.

@mmuckley
Copy link
Owner

mmuckley commented Aug 7, 2023

Hello @mxlutz, at the moment I'm a little bit hesitant to add this as core repo functionality, as it seems a bit small. However, if you wanted instead to start your own repo with subspace NUFFTs and maybe show a few examples, I'd be happy to link to it in the torchkbnufft README for any users that were interested in that. What do you think?

@mxlutz
Copy link
Author

mxlutz commented Aug 17, 2023

Yes, that makes sense. The solution with a separate repo sounds reasonable, thanks for offering to link it. I'll get in contact when I continued working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants