Skip to content

Adding print versioninfo and cleaning up build script for CI #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Adding print versioninfo and cleaning up build script for CI #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/scripts/ci-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,12 @@ else
MOVING=0
fi

cd $MMTK_JULIA_DIR

MMTK_MOVING=$MOVING make $build_type

cd $JULIA_PATH

# Clean first
make cleanall
# Build
# This will build the binding in MMTK_JULIA_DIR (defined in common.sh), and link it
# when building Julia, instead of using the set version defined in Julia itself
cp $BINDING_PATH/.github/scripts/Make.user $JULIA_PATH/
MMTK_PLAN=$plan MMTK_BUILD=$build_type make
MMTK_MOVING=$MOVING MMTK_PLAN=$plan MMTK_BUILD=$build_type make
Copy link
Member

@qinsoon qinsoon Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a comment here, saying that MMTK_JULIA_DIR is defined in common.sh, so this will build with the current binding directory (rather than the binding version defined in Julia).

# Run hello world
$JULIA_PATH/julia $HELLO_WORLD_JL
20 changes: 20 additions & 0 deletions .github/workflows/binding-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ jobs:
- name: Build Julia (Debug)
run: |
./.github/scripts/ci-build.sh debug ${{ inputs.gc_plan }} ${{ inputs.moving }}
- name: Print Julia version info
run: |
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
- name: Style check
run: |
./.github/scripts/ci-style.sh
Expand All @@ -52,6 +56,10 @@ jobs:
- name: Build Julia (Debug)
run: |
./.github/scripts/ci-build.sh debug ${{ inputs.gc_plan }} ${{ inputs.moving }}
- name: Print Julia version info
run: |
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
- name: Style check
run: |
./.github/scripts/ci-style.sh
Expand Down Expand Up @@ -95,6 +103,10 @@ jobs:
- name: Build Julia (Release)
run: |
./.github/scripts/ci-build.sh release ${{ inputs.gc_plan }} ${{ inputs.moving }}
- name: Print Julia version info
run: |
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
- name: Test Julia
run: |
./.github/scripts/ci-test-other.sh
Expand All @@ -117,6 +129,10 @@ jobs:
- name: Build Julia (Release)
run: |
./.github/scripts/ci-build.sh release ${{ inputs.gc_plan }} ${{ inputs.moving }}
- name: Print Julia version info
run: |
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
- name: Test Julia
run: |
./.github/scripts/ci-test-stdlib.sh
Expand All @@ -136,6 +152,10 @@ jobs:
- name: Build Julia (Release)
run: |
./.github/scripts/ci-build.sh release ${{ inputs.gc_plan }} ${{ inputs.moving }}
- name: Print Julia version info
run: |
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
- name: Test Julia
run: |
./.github/scripts/ci-test-LinearAlgebra.sh
Loading