-
Notifications
You must be signed in to change notification settings - Fork 10
Adding Makefile support #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59260bd to
4c3d9c4
Compare
4c3d9c4 to
10b698e
Compare
10b698e to
c2a1acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned a valid point: with this PR, the binding repo and the VM repo record the versions of each other. We need to break this circular dependency. As Julia requires the version of its dependencies and we cannot change it, we probably want to remove the Julia version from this repo. This means, we need to change our CI as well.
Considering that we are under time pressure to get this upstreamed, we may prioritize getting this change approved and merged upstream. These are what I suggest:
We can discuss more on this tomorrow. Hopefully this can make things easier, and we do not need to figure out how the new CI should look like in this short time frame. |
Great idea Yi. I think that all makes sense. I'll set it all up. |
d1d67bd to
eeb8ed1
Compare
eeb8ed1 to
c941fea
Compare
Adding support for building the binding from a Makefile.