Skip to content

Simplify type parameters for schedule_common() #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 15, 2021
Merged

Simplify type parameters for schedule_common() #487

merged 24 commits into from
Nov 15, 2021

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Oct 28, 2021 •
edited
Loading

This PR

  • adds a new trait GCWorkContext which provides a few associated types used for work packets. Each plan provides an implementation of GCWorkContext.
  • moves schedule_common from CommonPlan to GCWorkScheduler.
  • fixes tutorial code for the changes in Extract common work packet to schedule_common() #471.

@qinsoon qinsoon changed the title GC work context for plans Simplify type parameters for schedule_common() Oct 28, 2021
wks
wks reviewed Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the schedule_common method may be moved to the Plan trait. This is a bit different from how we would do it in Java (JikesRVM). Rust is different.

@qinsoon
Copy link
Member Author

qinsoon commented Oct 29, 2021

I feel the schedule_common method may be moved to the Plan trait. This is a bit different from how we would do it in Java (JikesRVM). Rust is different.

Thanks for the comments -- I will work on them.

@qinsoon qinsoon marked this pull request as ready for review November 3, 2021 00:33
@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Nov 3, 2021
@qinsoon qinsoon mentioned this pull request Nov 4, 2021
Merged
wks
wks requested changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few comments that need updating.

@qinsoon
Copy link
Member Author

qinsoon commented Nov 8, 2021

I have addressed the reviews. @wks

wks
wks approved these changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 1fc31f6 into master Nov 15, 2021
@qinsoon qinsoon deleted the gc-work-context branch November 15, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wks wks wks approved these changes

Assignees

No one assigned

Labels

PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qinsoon @wks