Cleaning up after bumping Rust MSRV #1442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start using the MSRV-aware resolver (
resolver = "3").We bumped dependency versions.
sysinfoandcriterion) below the latest version because their latest versions require higher MSRV and newer Rust editions.0.7.2, it will be equivalent to>=0.7.2,<0.8.0. So if0.7.4is compatible but0.7.5is not, it will resolve to0.7.4. But if0.7.2is incompatible, the resolver will refuse to go below0.7.2, and the resolution will fail. Bothsysinfoandcriterionbroke MSRV compatibility when bumping a minor version (since the major versions are 0, minor version signifies incompatibility), so the MSRV-aware resolver is not helping for those two specific dependencies.Removed a workaround in
ByteMapStateStorage::newwhere we could useconst {}to initialize a vector without copying.