Make EDGES_WORK_BUFFER_SIZE constant public to bindings
#1291
Conversation
| /// such as roots gathering code or weak reference processing. In order to have better load | ||
| /// balancing, it is recommended that binding developers use this constant to split work up into | ||
| /// different work packets. | ||
| pub const EDGES_WORK_BUFFER_SIZE: usize = 4096; |
There was a problem hiding this comment.
You can just re-export it. See the pub use below.
There was a problem hiding this comment.
I thought it'd be better to actually have all constants together in mod.rs like we do for many other cases like in immix/mod.rs for example.
There was a problem hiding this comment.
The title suggested that you just wanted to make the constant public to bindings. I was suggesting pub use is the straightforward way to achieve that.
There was a problem hiding this comment.
Right. But I thought it made sense to move the constant so that if we ever have other scheduler constants, they are not scattered around the different files. Up to you. I can move it back and re-export
There was a problem hiding this comment.
It looks okay. I think the difference is insigifnicant whether we put the constants in the top-level modules or lower-level submodules. There is no convention to require either way so it is your choice.
2 participants
No description provided.