implement mutator builder #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@tianleq Could you edit this post #1287 (comment) to include introductions of the purpose of this commit? In our current CI, the content of the merge request will become the commit message of the squashed commit. |
qinsoon
reviewed
Mar 20, 2025
Member
qinsoon
left a comment
qinsoon
left a comment
There was a problem hiding this comment.
LGTM. We can create Allocators when we build Mutator (instead of MutatorBuilder).
qinsoon
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mmtk.zulipchat.com/#narrow/channel/262673-mmtk-core/topic/create.20plan.2Fmutator/near/504996362
Introducing
MutatorBuilderto simplify customisingMutator, adding/removing fields of a certain plan'sMutatorno longer affects other plan asMutatorBuilderprovides default values forMutator