Skip to content

Skip iterating through unallocated memory for MonotonePageResource #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Skip iterating through unallocated memory for MonotonePageResource #1189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d8422
Skip iterating through unallocated memory for `MonotonePageResource`
k-sareen Aug 28, 2024
e56a18e
Add comment
k-sareen Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/util/heap/monotonepageresource.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,13 @@ impl<VM: VMBinding> MonotonePageResource<VM> {
} else {
let start = self.discontiguous_start;
self.discontiguous_start = self.pr.vm_map().get_next_contiguous_region(start);
let size = self.pr.vm_map().get_contiguous_region_size(start);
// If the current cursor is within the current discontiguous region (i.e. chunk),
// then return the size till the cursor
let size = if self.pr.cursor().chunk_index() == start.chunk_index() {
self.pr.cursor() - start
} else {
self.pr.vm_map().get_contiguous_region_size(start)
};
Some((start, size))
}
}
Expand Down