Parallelize and workaround CI style checks #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now do style checks for all architectures on ubuntu-latest using cross toolchains. That makes style check failures manifest faster, and avoids a crash of `cargo clippy` on macos. Also fixed missing style checks for non-mock benchmarks.
|
|
wks
changed the title
qinsoon
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now do style checks in parallel to
cargo testso that style problems will fail fast.Black-listed clippy 0.1.77 on x86_64-apple-darwin because it is known to crash randomly.
Also added missing style checks for non-mock benchmarks.