Skip to content

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Jul 1, 2024

This PR bumps the version to v0.26.

@qinsoon qinsoon requested a review from wks July 1, 2024 02:38
@wks
Copy link
Collaborator

wks commented Jul 1, 2024

If we want to change the MSRV policy, we should discuss in a group, with @steveblackburn and @caizixian involved. From our previous discussion, we acknowledge that MMTk is a research project and may be aggressive with the technology we use. Our lab machine images are updated automatically, so our burden of maintenance is not high. We should also communicate with our collaborators and see if there are requirements for a less aggressive MSRV policy.

@qinsoon qinsoon changed the title Bump version to v0.26. Update our MSRV policy to N-4. Bump version to v0.26 Jul 1, 2024
@qinsoon
Copy link
Member Author

qinsoon commented Jul 1, 2024

I removed the changes about the MSRV policy in this PR. But I still suggest we adopt a less aggressive policy.

We currently use N-1. But in practice, we are not aggressively moving the MSRV, as we know sticking to N-1 all the time would bring troubles, and that is not desirable. However, sticking to N-1 is a valid option according to our policy. Using N-4 or something similar would set a more clear expectation for our users and contributors.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon
Copy link
Member Author

qinsoon commented Jul 1, 2024

binding-refs
OPENJDK_BINDING_REPO=qinsoon/mmtk-openjdk
OPENJDK_BINDING_REF=v0.26
JIKESRVM_BINDING_REPO=qinsoon/mmtk-jikesrvm
JIKESRVM_BINDING_REF=v0.26

@qinsoon qinsoon added this pull request to the merge queue Jul 1, 2024
@qinsoon qinsoon removed this pull request from the merge queue due to a manual request Jul 1, 2024
@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Jul 1, 2024
@qinsoon qinsoon added this pull request to the merge queue Jul 1, 2024
Merged via the queue into mmtk:master with commit 6cae51c Jul 1, 2024
@qinsoon qinsoon deleted the v0.26 branch July 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-extended-testing Run extended tests for the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants