-
Notifications
You must be signed in to change notification settings - Fork 78
Remove data race for marksweep block lists #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cd28069 to
44fb3f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments. One strange thing is that once a Block becomes BlockState::Marked, it remain marked forever. But I think the block state of all marked blocks should be reset to unmarked so that we can find blocks that actually have marked objects.
|
Style check failed due to trailing spaces. If you use VSCode, there are extensions for highlighting trailing spaces and removing them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field BlockList::lock and its methods BlockList::lock() and BlockList::unlock() are unused. We can remove them now.
I kept the methods just in case we may need them in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR refactors mark sweep.