Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.22.1 #1066

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Bump version to v0.22.1 #1066

merged 2 commits into from
Jan 11, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 11, 2024

Bumps the version to v0.22.1 for #1065.

@qinsoon qinsoon requested a review from wks January 11, 2024 06:24
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wks
Copy link
Collaborator

wks commented Jan 11, 2024

Oops. The CI style test failed. The --dry-run flag should pretend that mmtk-macros has been successfully uploaded, but it doesn't.

There is an on-going discussion upstream about multi-crate uploading and its corresponding --dry-run: rust-lang/cargo#1169

@qinsoon
Copy link
Member Author

qinsoon commented Jan 11, 2024

Oops. The CI style test failed. The --dry-run flag should pretend that mmtk-macros has been successfully uploaded, but it doesn't.

There is an on-going discussion upstream about multi-crate uploading and its corresponding --dry-run: rust-lang/cargo#1169

Ummm. I just removed the cargo publish --dry-run from the script, as it seems no way to work around it.

@qinsoon qinsoon added this pull request to the merge queue Jan 11, 2024
Merged via the queue into mmtk:master with commit 9f0c218 Jan 11, 2024
19 checks passed
@qinsoon qinsoon deleted the v0.22.1 branch January 11, 2024 22:36
qinsoon added a commit that referenced this pull request Jan 12, 2024
Bumps the version to v0.22.1 for
#1065.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants