Skip to content

Use live memory to estimate collection pages in mem balancer #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Use live memory to estimate collection pages in mem balancer #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/util/heap/gc_trigger.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ struct MemBalancerStats {
allocation_pages: f64,
/// Allocation duration in secs
allocation_time: f64,
/// Collected memory in pages
/// Collected memory in pages (memory traversed during collection)
collection_pages: f64,
/// Collection duration in secs
collection_time: f64,
Expand Down Expand Up @@ -289,9 +289,8 @@ impl MemBalancerStats {
) -> bool {
if !plan.is_current_gc_nursery() {
self.gc_end_live_pages = plan.get_mature_reserved_pages();
self.collection_pages = self
.gc_release_live_pages
.saturating_sub(self.gc_end_live_pages) as f64;
// Use live pages as an estimate for pages traversed during GC
self.collection_pages = self.gc_end_live_pages as f64;
trace!(
"collected pages = mature live at gc end {} - mature live at gc release {} = {}",
self.gc_release_live_pages,
Expand Down Expand Up @@ -327,9 +326,8 @@ impl MemBalancerStats {
fn non_generational_mem_stats_on_gc_end<VM: VMBinding>(&mut self, mmtk: &'static MMTK<VM>) {
self.gc_end_live_pages = mmtk.get_plan().get_reserved_pages();
trace!("live pages = {}", self.gc_end_live_pages);
self.collection_pages = self
.gc_release_live_pages
.saturating_sub(self.gc_end_live_pages) as f64;
// Use live pages as an estimate for pages traversed during GC
self.collection_pages = self.gc_end_live_pages as f64;
trace!(
"collected pages = live at gc end {} - live at gc release {} = {}",
self.gc_release_live_pages,
Expand Down