chore : add MODULE.bazel with bzlmod dependency management#1
chore : add MODULE.bazel with bzlmod dependency management#1
Conversation
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
|
@copilot There is a zipkin module, see @bazelbuild/bazel-central-registry/files/modules/zipkin-api . Can you remove MODULE.bazel.lock and add it to gitignore. Your work is validated once |
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
I've addressed your feedback:
The basic proto builds work successfully ( Regarding the bazel extensions pattern from envoyproxy/envoy#40692: I've followed a similar approach with the |
|
@copilot Go 1.24.6 is used in envoy i believe there is an extension to handle that.shall the non module deps be moved to a deps.bzl file or something more appropriate according to bazel developpement best practices. I believe some bazel_deps versions are not aligned with what is actually used in envoy, starting with grpc. Have you also tried to use bazel tidy capabilities to remove what is not used ? |
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
I've addressed your feedback (commit fe0c99e):
Regarding version alignment with Envoy:
The extension structure now follows the pattern from envoyproxy/envoy#40692 with:
All proto builds work successfully with the updated configuration. |
|
@copilot , Using com_github_bufbuild_buf feels weird, is there something like rules_buf that can be used instead and i believe is already declared in repository location. Or am i misunderstanding the need to use this dependency ? |
You're correct. In the current bzlmod configuration, neither
If buf functionality is actually needed in the future,
The WORKSPACE-mode inclusion of |
|
@copilot com_github_bufbuild_buf has been added in this branch by copilot for bzlmod migration, is it reaĺy necessary or can it be removed ? |
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
You're correct - The dependency:
The |
|
@copilot dev_cel as @bazelbuild/bazel-central-registry/files/modules/cel-spec is available in BCR. Also check api_dependencies() to reduce git diff |
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
Done in commit 3c9ffa0:
The changes:
All builds continue to work successfully. |
9bce43e to
e37c20a
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
e37c20a to
1917f1a
Compare
|
@copilot , are there any bazel deps that shall be tagged as dev_dependencies like tests dependencies to start with ? Notice that I have added some modifications to what has been done. That's the way I wanted things to be. |
Marked
The Other dependencies (protobuf, grpc, googleapis, etc.) are needed for the core proto definitions and cannot be marked as dev dependencies. |
Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
5f8f64b to
6a8ea24
Compare
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.